Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Older (pre 1.12) campaigns can fail to load due to templates/drawings that have no quadrant, #4095

Closed
cwisniew opened this issue May 29, 2023 · 3 comments
Assignees
Labels

Comments

@cwisniew
Copy link
Member

Describe the Bug

If an old campaign containing a template or drawing without a quadrant is loaded in 1.13 (and probably earlier) it will fail and the campaign wont load.

To Reproduce

Load a campaign with this issue (finding one is easier said than done though)

Expected Behaviour

The map should load

Screenshots

image

MapTool Info

No response

Desktop

No response

Additional Context

No response

@kwvanderlinde
Copy link
Collaborator

Okay, not sure how you ended up with a campaign like this. It would either have to be really old (beyond my visibility) or else our logic messed up somewhere along the way and made this by accident ...

I tested this by manually hacking the quadrant out of an existing line template and things check out. But if you have a campaign that still has this issue I also can try it on that.

@cwisniew
Copy link
Member Author

Okay, not sure how you ended up with a campaign like this. It would either have to be really old (beyond my visibility) or else our logic messed up somewhere along the way and made this by accident ...

I tested this by manually hacking the quadrant out of an existing line template and things check out. But if you have a campaign that still has this issue I also can try it on that.

Someone supplied as really old one :) Unfortunately, I can no longer recall who or find the campaign I used to find/test it.

@kwvanderlinde
Copy link
Collaborator

I'm happy to close this off then. We can revisit if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

2 participants