Fix for NPE reading old campaigns #4096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Fixes #4095
Description of the Change
Fixes the NPE on loading old campaigns where there is no quadrant for dodgy drawings/templates.
I have also moved setting of name and playerAlias in Zone.toDto() to the top of the method as it makes debugging these kinds of issues a lot easier.
Possible Drawbacks
These campaigns will now load, but there may be cases where dodgy drawings/templates did not appear on the map pre 1.12 but do now. But this is vastly more preferable than the campaign not being able to load at all
Documentation Notes
Release Notes
This change is