Feature: Token VBL simplification #1435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tps://github.com/RPTools/maptool into develop"" This reverts commit f7500b4 Signed-off-by: JamzTheMan <[email protected]>
…plification-revert-revert Feature token vbl simplification revert revert
…/RPTools/maptool into feature-token-vbl-simplification
Signed-off-by: JamzTheMan <[email protected]>
Signed-off-by: JamzTheMan <[email protected]>
…plification Feature token vbl simplification RPTools#1218
…tps://github.com/RPTools/maptool into develop"" This reverts commit f7500b4 Signed-off-by: JamzTheMan <[email protected]>
Signed-off-by: JamzTheMan <[email protected]>
Signed-off-by: JamzTheMan <[email protected]>
* No long requires 'valid geometry' which allows for vbl with 'holes' #needsTesting Signed-off-by: JamzTheMan <[email protected]>
…/JamzTheMan/MapTool into feature-token-vbl-simplification
* No long requires 'valid geometry' which allows for vbl with 'holes' * Fix tokenPropertiesDialog.xml to use generic label vs RSyntax beans so they are not needed when using forms designer which just removes the component if you didn't have forms designer setup properly. #needsTesting Signed-off-by: JamzTheMan <[email protected]>
* No long requires 'valid geometry' which allows for vbl with 'holes' * Fix tokenPropertiesDialog.xml to use generic label vs RSyntax beans so they are not needed when using forms designer which just removes the component if you didn't have forms designer setup properly. #needsTesting Signed-off-by: JamzTheMan <[email protected]>
* Performance increase upwards of 50x * doubleclick on preview window resets preview scaling * No long requires 'valid geometry' which allows for vbl with 'holes' * Fix tokenPropertiesDialog.xml to use generic label vs RSyntax beans so they are not needed when using forms designer which just removes the component if you didn't have forms designer setup properly. #needsTesting Signed-off-by: JamzTheMan <[email protected]>
…plification Feature token vbl simplification
* Performance increase upwards of 50x * doubleclick on preview window resets preview scaling * No long requires 'valid geometry' which allows for vbl with 'holes' * Fix tokenPropertiesDialog.xml to use generic label vs RSyntax beans so they are not needed when using forms designer which just removes the component if you didn't have forms designer setup properly. * Added threading in a few places for performance and for proper UI updates * Added Color Picker; you are no longer restricted to just transparency but can now pick a color. Although a popular color like Black may be overzealous. * Lots of bug fixes and improvements * Updated UI to final preview * Tested with very large maps (10,000 x 10,000 pixels) takes ~30-40 seconds but UI no longer locks up and dialog can be closed. Most objects take <1 second. Signed-off-by: JamzTheMan <[email protected]>
* Performance increase upwards of 50x * doubleclick on preview window resets preview scaling * No long requires 'valid geometry' which allows for vbl with 'holes' * Fix tokenPropertiesDialog.xml to use generic label vs RSyntax beans so they are not needed when using forms designer which just removes the component if you didn't have forms designer setup properly. * Added threading in a few places for performance and for proper UI updates * Added Color Picker; you are no longer restricted to just transparency but can now pick a color. Although a popular color like Black may be overzealous. * Lots of bug fixes and improvements * Updated UI to final preview * Tested with very large maps (10,000 x 10,000 pixels) takes ~30-40 seconds but UI no longer locks up and dialog can be closed. Most objects take <1 second. Signed-off-by: JamzTheMan <[email protected]>
* Performance increase upwards of 50x * doubleclick on preview window resets preview scaling * No long requires 'valid geometry' which allows for vbl with 'holes' * Fix tokenPropertiesDialog.xml to use generic label vs RSyntax beans so they are not needed when using forms designer which just removes the component if you didn't have forms designer setup properly. * Added threading in a few places for performance and for proper UI updates * Added Color Picker; you are no longer restricted to just transparency but can now pick a color. Although a popular color like Black may be overzealous. * Lots of bug fixes and improvements * Updated UI to final preview * Tested with very large maps (10,000 x 10,000 pixels) takes ~30-40 seconds but UI no longer locks up and dialog can be closed. Most objects take <1 second. Signed-off-by: JamzTheMan <[email protected]>
Signed-off-by: JamzTheMan <[email protected]>
Signed-off-by: JamzTheMan <[email protected]>
* VBL_Functions google code cleanup
* setTokenVBL "shape": "auto" updated for auto-generation options
sample: `[h: options = json.set("{}", "shape", "auto", "sensitivity", 10, "inverse", 0, "level", 2, "method", "Douglas Peucker", "r", 0, "g", 0, "b", 0, "a", 255)]`
Signed-off-by: JamzTheMan <[email protected]>
Signed-off-by: JamzTheMan <[email protected]>
JamzTheMan
added
feature
Signed-off-by: JamzTheMan <[email protected]>
Phergus
approved these changes
Mar 30, 2020
There was a problem hiding this comment.
Reviewed 10 of 10 files at r1, 1 of 1 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various highlights from commits...
sample:
[h: options = json.set("{}", "shape", "auto", "sensitivity", 10, "inverse", 0, "level", 2, "method", "Douglas Peucker", "r", 0, "g", 0, "b", 0, "a", 255)]so they are not needed when using forms designer which just removes
the component if you didn't have forms designer setup properly.
Closes #1218 - Optimize Token VBL Generation
This change is