Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update InitiativePanel.java #3066

Merged
merged 4 commits into from
Oct 17, 2021
Merged

Conversation

Phergus
Copy link
Contributor

@Phergus Phergus commented Oct 16, 2021

Identify the Bug or Feature request

Corrects problem seen in #233

Description of the Change

Remove space bar from the input map for the Initiative panel buttons so that folks don't accidentally advance/rewind/pause initiative.

Possible Drawbacks

Maybe someone wants space-bar to advance initiative?

Documentation Notes

Hitting space-bar will no longer activate the last button clicked on the Initiative panel.

Release Notes

  • Hitting space-bar will no longer activate the last button clicked on the Initiative panel.

This change is Reviewable

Remove space bar from the input map for the Initiative panel buttons so that folks don't accidentally advance/rewind/pause initiative.
@kwvanderlinde
Copy link
Collaborator

The change looks good to me as-is. That said, do we also want to disable other keys that behave similarly (such as Enter)? Or is only Space considered special here because it's also used for showing a pointer?

@Phergus
Copy link
Contributor Author

Phergus commented Oct 17, 2021

That said, do we also want to disable other keys that behave similarly (such as Enter)? Or is only Space considered special here because it's also used for showing a pointer?

I suspect the space-bar is the usual culprit for that very reason but perhaps blocking out the Enter key would be a good idea as well. Are there other keys that would trip the buttons?

@Phergus
Copy link
Contributor Author

Phergus commented Oct 17, 2021

Excluding ENTER key as well.

Copy link
Member

@cwisniew cwisniew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Phergus)

@cwisniew cwisniew merged commit 0f3d935 into RPTools:develop Oct 17, 2021
@Phergus Phergus deleted the spacebarButtonAdvance233 branch October 22, 2021 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants