Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add off-state icons to VBL tools #3181

Merged
merged 2 commits into from
Nov 16, 2021
Merged

Conversation

Phergus
Copy link
Contributor

@Phergus Phergus commented Nov 15, 2021

Identify the Bug or Feature request

Update to #2755

Description of the Change

VBL mode selection can be hard to see when Windows display scaling is enabled. This adds button icons for the deselected state.

Possible Drawbacks

I'm sure there is something...

Documentation Notes

When a VBL mode is enabled the color icon is used. When disabled the sepia icon is used.

Release Notes

  • VBL mode buttons now have two images to reflect on/off.

This change is Reviewable

Adding icons for the off-state of the VBL modes.
Copy link
Collaborator

@kwvanderlinde kwvanderlinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Phergus)

@Phergus Phergus merged commit 3fd6b7f into RPTools:develop Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants