Remove unnecessarily translated strings #3711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add data to AssetDto to actually transfer the asset to server.
Necessitated adding a null check when getting translations to avoid a crash Also added an empty check to avoid the logs getting filled with "failed to translate ''" messages
|
@ChrisCookOC you need to run |
|
Have run the spotless apply and updated :) |
Phergus
approved these changes
Oct 21, 2022
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, 2 of 3 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ChrisCookOC)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2837
Description of the Change
Remove unnecessary translations - placeholders that are never displayed.
Necessitated adding a null check when getting translations to avoid a crash
Also added an empty check to avoid the logs getting filled with "failed to translate ''" messages
Possible Drawbacks
The pull request seems to have the contents of the previously accepted pull request in as well. #3707 Seems the last commit didn't go into develop. Not sure if I should be committing this against a branch pulled from the 1.13 release and pull requesting to there directly - if so, let me know :)
Documentation Notes
Release Notes
Remove unnecessary terms from needing to be translated
This change is