Replace EventDispatcher with Guava's EventBus #3741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're already using `EventBus` for some things, but there were others on `EventDispatcher`. Now only `EventBus` remains with `EventDispatcher`, `AppEvent` and `AppEventListener` being no more. The mapping from the previous event tags to the current event types is: - `MapTool.ZoneEvent.Activated`: `ZoneActivated` - `MapTool.ZoneEvent.Deactivated`: `ZoneDeactivated` - `MapTool.ZoneEvent.Added`: `ZoneAdded` - `MapTool.ZoneEvent.Removed`: `ZoneRemoved` - `MapTool.PreferencesEvent.Changed`: `PreferencesChanged` The `Deactivated` was previously unused since the `Activated` event could contain an old and new value in the `AppEvent`. But it's cleaner in the new system for subscribers to handle deactivation and activation separately and allows the `ZoneActivated` and `ZoneDeactivated` types to be focused on a single zone. So we now conditionally post a `ZoneDeactivated` event prior to `ZoneActivated` when necessary.
cwisniew
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Relates to #1827
Description of the Change
EventBusis already in use for some events, but others events were still based onEventDispatcher/AppEvent. Now onlyEventBusexists withEventDispatcherand related classes being removed.Possible Drawbacks
Shouldn't be any, outside of some unforeseen issue with
EventBus.Documentation Notes
N/A (refactoring)
Release Notes
N/A
This change is