Remove extra vision transform that is no longer needed in VisibilityInspector #3820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Phergus
approved these changes
Jan 29, 2023
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @kwvanderlinde)
kwvanderlinde
deleted the
bugfix/3747-visibility-inspector-fix-extra-transforms
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Relates to #3747, fixes a bug in PR #3813
Description of the Change
With the recent change to
FogUtil.calculateVisibility()no longer transforming the vision areas,VisibilityInspectorwas not correctly updated to handle those changes. The obstructed vision was still being transformed after callingFogUtil.calculateVisibility()despite being created from an area that was already transformed.Possible Drawbacks
None. Applies to the VisibilityInspector not part of MapTool proper.
Documentation Notes
N/A
Release Notes
N/A
This change is