Stop rounding *BL points #3864
Merged
Stop rounding *BL points #3864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thelsing
approved these changes
Mar 16, 2023
Phergus
approved these changes
Mar 16, 2023
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @kwvanderlinde)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Addresses #3763
Description of the Change
Closed polygon shapes passed to
setToken*BL()ordraw*BL()were reading the point coordinates as integers, ignoring any fractional parts (this did not apply to unclosed "polygons"). This change combines the closed/unclosed cases into one case and reads the coordinates as doubles.On the
getToken*BL()/get*BL()side, the coordinates of the returned polygon were being truncated after the hundredth place. This truncation is now removed so that the functions returns as values that are as precise as possible.Possible Drawbacks
The results of
getToken*BL()/get*BL()will generally be much longer due to the new precision. This could have performance implications in extreme cases, in particular if the results are operated on as strings. The results are also less readable if they need to be inspected by a human.Documentation Notes
I don't think it's worth adding documentation as this is just a precision change.
Release Notes
setTokenVBL(),drawVBL()and related functions were truncating fractional coordinates.This change is