Flush aura cache when tokens with auras are changed #4058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `drawableAura` cache was optionally flushed based on whether the token currently has light sources or contributions to an illumination. Auras don't interact with illumination, so this was missing tokens that used to have auras but now have no light sources. The new checks separate auras from normal lights. The aura cache is now cleared whenever the token is recognized as an aura source, or just been given an aura.
cwisniew
approved these changes
May 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Fixes #4057
Description of the Change
Auras were being cleared based on the vision and lighting properties of the token. Auras have nothing to do with these, so the cache was not being reliably cleared. Now we check auras separately, and if the token either has or had an aura we clear the
drawableAurascache.Some cleanup as well: the
lightSourceMapwas simplified by guaranteeing that all keys will exist and be mapped to valid sets. This avoids the need to check on every access, making things easier to follow and avoiding easy-to-introduce NPEs (I hit this on my first take).Possible Drawbacks
Should be none.
Documentation Notes
N/A
Release Notes
This change is