Fix for gaps in initative list #4074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
#3310
Description of the Change
Various scenarios can lead to there being a "gap" in the initiative list. Campaigns that have gaps in the initiative list of one or more maps load successfully but copying the zone during server start results in a null pointer exception, and the server will not start leaving MapTool in an undefined state.
This fix recreates the initiative list without gaps on zone copy.
Possible Drawbacks
Hopefully none.
Documentation Notes
Fix issue where server may not start if initiative list has developed gaps.
Release Notes
This change is