Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable developer options by default #4329

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

kwvanderlinde
Copy link
Collaborator

@kwvanderlinde kwvanderlinde commented Oct 19, 2023

Identify the Bug or Feature request

Improves #4061, fixing an issue with #4063

Description of the Change

The default value for the preference lookup has been fixed to be false so that the devleoper options are by default considered disabled.

The developer options are also in a different node so they stay separate from regular application preferences. This will make it easier to manipulate during testing without messing with all the other preferences.

Possible Drawbacks

None

Documentation Notes

N/A

Release Notes

N/A


This change is Reviewable

Also store developer options in a separate preference node to keep them separate from regular application
preferences. This should make testing and fixups a little easier.
@kwvanderlinde kwvanderlinde force-pushed the bugfix/4061-dev-options-enabled-by-default branch from a3a5c30 to 8583bb4 Compare October 19, 2023 00:14
@cwisniew cwisniew added this pull request to the merge queue Oct 19, 2023
Merged via the queue into develop with commit 80fa735 Oct 19, 2023
4 checks passed
@kwvanderlinde kwvanderlinde deleted the bugfix/4061-dev-options-enabled-by-default branch October 19, 2023 08:37
@cwisniew cwisniew added the bug label Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

2 participants