Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for windows duplicate file issue #4337

Merged
merged 2 commits into from
Oct 20, 2023

Conversation

cwisniew
Copy link
Member

@cwisniew cwisniew commented Oct 20, 2023

Identify the Bug or Feature request

Fixes #4336
Fixes #4320

Description of the Change

Set the java.util.Arrays.useLegacyMergeSort property to true so that the legacy merge sort (which does not require a stable sort) instead of timsort is used in the swing dialog (well everywhere really).

Possible Drawbacks

Smaller arrays will be less efficient to sort, but on the plus side people experiencing this issue will be able to save and load. When its fixed in the JDK we can easily revert this change.

Documentation Notes

Work around for error encountered when you have two files with same name in windows (happens with dropbox, google drive, mega drive etc...)

Release Notes

  • Work around for error encountered when you have two files with same name in windows (happens with dropbox, google drive, mega drive etc...)

This change is Reviewable

@cwisniew cwisniew changed the base branch from develop to release-1.14 October 20, 2023 04:44
@cwisniew cwisniew added the bug label Oct 20, 2023
@cwisniew cwisniew merged commit 149696d into RPTools:release-1.14 Oct 20, 2023
4 checks passed
@cwisniew cwisniew deleted the fix-windows-dup-filename branch October 20, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

[Bug]: Open / Save dialog can fail to open under windows 10/11 when there are duplicate files
3 participants