Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add nightly github action #4411

Merged
merged 28 commits into from
Nov 22, 2023
Merged

add nightly github action #4411

merged 28 commits into from
Nov 22, 2023

Conversation

cwisniew
Copy link
Member

@cwisniew cwisniew commented Nov 17, 2023

Identify the Bug or Feature request

Resolves #4450

Description of the Change

Creates nightly builds of MapTool

Possible Drawbacks

  • The cron based actions for GitHub are known to be flakey, they will not run if the GitHub actions platform is too busy, I have tried to mitigate this by running it at an odd time (i.e. not an hour or half hour or 20 or 15 minute multiple when many other cron based jobs might be running). We will see how it goes, but its not the end of the world if the odd build doesn't get created while we are trialling it. (It was actually a bit fiddly to get working until google pointed me to comments saying it wont run at busy periods)
  • This script does not delete old nightlies but for now, I can manage that manually by deleting them every now and again.
  • Nightlys will get build even if there are no changes.

Documentation Notes

Nightly MapTool Builds are now available

Release Notes

  • Nightly MapTool Builds are now available

This change is Reviewable

@cwisniew cwisniew marked this pull request as draft November 17, 2023 10:40
@cwisniew cwisniew marked this pull request as ready for review November 22, 2023 12:09
@cwisniew cwisniew added the feature Adding functionality that adds value label Nov 22, 2023
@cwisniew cwisniew added this pull request to the merge queue Nov 22, 2023
Merged via the queue into RPTools:develop with commit 3ecc1b3 Nov 22, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Adding functionality that adds value
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Create nightly Builds
2 participants