Input() to handle lib:// asset paths
#4621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… icon regex and pass through the AssetResolver to handle library assets as well as standard assets.
cwisniew
requested changes
Jan 8, 2024
src/main/java/net/rptools/maptool/client/functions/InputFunction.java
Outdated
Show resolved
Hide resolved
cwisniew
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
resolves #4620
Description of the Change
Updates regex to capture asset string and pass through AssetResolver to handle both
asset://andlib://pathsPossible Drawbacks
None
Documentation Notes
Regex capture includes the 'asset://' OR 'lib://' portion of the URI
Now depends on Asset Resolver
Release Notes
Added ability for Input() to handle
lib://URIsThis change is