Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port missing 1.14 commits to 1.15 #4950

Conversation

kwvanderlinde
Copy link
Collaborator

@kwvanderlinde kwvanderlinde commented Sep 27, 2024

Identify the Bug or Feature request

Addresses #4895

Description of the Change

This ports PRs #4508 (776e07d) and #4433 (4e86d68) from release-1.14 to release-1.15. These commits got overlooked and were never merged back into develop.

In a follow-up PR, I'll also port the changes to latest develop.

Possible Drawbacks

None

Documentation Notes

N/A

Release Notes

  • Fixed a bug where HTML events are not forward to Java when nested elements are dynamically added to the DOM.

This change is Reviewable

Instead of `cp`, using `mv` has some nicer behaviour on Windows and Mac OS, while also being decent on Linux too.

Cherry pick of 4e86d68
HTML5 event listeners are now registered as before. However, to avoid peering issues in JavaFX <22, new listeners are
created each time the page is unloaded.

Cherry pick of 776e07d
@kwvanderlinde kwvanderlinde self-assigned this Sep 27, 2024
@cwisniew cwisniew merged commit 6ca0e16 into RPTools:release-1.15 Sep 27, 2024
4 checks passed
@kwvanderlinde kwvanderlinde deleted the bugfix/port-missing-1.14-commits-to-1.15 branch September 27, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants