-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert to Typescript #2
base: main
Are you sure you want to change the base?
Conversation
src/Hs.ts
Outdated
charts:Charts | ||
_mappedGetters | ||
_mappedActions | ||
[key: string]: any |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this catching? Ideally everything assigned to the object should be pre-defined or put in some other data structure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, excellent catch. I'm not sure why I had that in there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I forgot I had the // @ts-nocheck
at the top of the file, so of course there was no change when I changed it.
[key: string]: any
is meant to catch this[getter]
and this[action]
on lines 44-54.
Not converted yet:
getDefaultOption.js
,mixin.js
, and several functions inHs.ts
which are used by harness-ui.0 errors as is, with the
@ts-ignore
comments.