Convert to Typescript #2
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdpdev
reviewed
Oct 28, 2021
src/Hs.ts
Outdated
| charts:Charts | ||
| _mappedGetters | ||
| _mappedActions | ||
| [key: string]: any |
There was a problem hiding this comment.
What is this catching? Ideally everything assigned to the object should be pre-defined or put in some other data structure
There was a problem hiding this comment.
Thank you, excellent catch. I'm not sure why I had that in there.
There was a problem hiding this comment.
Actually, I forgot I had the // @ts-nocheck at the top of the file, so of course there was no change when I changed it.
[key: string]: any is meant to catch this[getter] and this[action] on lines 44-54.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not converted yet:
getDefaultOption.js,mixin.js, and several functions inHs.tswhich are used by harness-ui.0 errors as is, with the
@ts-ignorecomments.