Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update link for online LDA paper #3141

Merged
merged 2 commits into from
May 14, 2021
Merged

Update link for online LDA paper #3141

merged 2 commits into from
May 14, 2021

Conversation

dymil
Copy link
Contributor

@dymil dymil commented May 13, 2021

The old link was broken, as Blei moved from Princeton to Columbia. The code link is also broken, but, alas, I don't know anywhere it's still alive.

@mpenkov mpenkov added the documentation Current issue related to documentation label May 14, 2021
@mpenkov
Copy link
Collaborator

mpenkov commented May 14, 2021

Thank you for your contribution @dymil ! Congrats on your first PR to gensim 🥇 !!

@mpenkov mpenkov merged commit 69ba51e into piskvorky:develop May 14, 2021
@jonaschn
Copy link
Contributor

@mpenkov Where is this wiki displayed on the website?
I did not come across this page earlier.
I find the notice regarding running LDA in batch mode really helpful.

@dymil
The code can be found here: https://github.com/blei-lab/onlineldavb/blob/master/onlineldavb.py
The paper URL should better be https://papers.neurips.cc/paper/2010/file/71f6278d140af599e06ad9bf1ba03cb0-Paper.pdf
Otherwise your URL will be outdated when Blei moves from Columbia to somewhere else.

@mpenkov
Copy link
Collaborator

mpenkov commented May 14, 2021

@jonaschn https://radimrehurek.com/gensim/wiki.html

Can you make a PR with the new links?

@dymil
Copy link
Contributor Author

dymil commented May 14, 2021

#3142

@dymil dymil deleted the patch-1 branch May 14, 2021 13:57
@jonaschn
Copy link
Contributor

@mpenkov Thanks. The wiki page should (in my opinion) be presented more prominently.
I totally missed this benchmark page although I am using gensim for a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Current issue related to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants