Fix broken external link for LDA implementation #3190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I'm not a fan of updating our docs every time someone changes departments though. Can you think of a better way to handle this? Google shows me https://github.com/blei-lab/lda-c . Looks semi-official… maybe we can link to that? |
|
Thanks for the comment, I fixed the link to be more permanent. |
piskvorky
reviewed
Apr 22, 2022
|
|
||
| +--------------------------------------------------------------------------------------------------------------+-----------+---------+ | ||
| | :ref:`sphx_glr_auto_examples_core_run_corpora_and_vector_spaces.py` (``run_corpora_and_vector_spaces.py``) | 00:03.242 | 48.2 MB | | ||
| | :ref:`sphx_glr_auto_examples_core_run_corpora_and_vector_spaces.py` (``run_corpora_and_vector_spaces.py``) | 02:36.161 | 40.1 MB | |
There was a problem hiding this comment.
This is weird. From 3 seconds to 2.5 minutes? What happened?
There was a problem hiding this comment.
I'm not sure. I ran the build again on my linux dev machine (the previous one was on MacOS) and the time is more appropriate (5s).
|
Merged. Thank you @ahaya3776 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old link was broken since Blei moved from Princeton to Columbia, as mentioned in #3141. It seems there was LDA implementation in C, and I fixed the link.