support for lnd v0.9.0 #71
Conversation
src/types/rpc/router-rpc.ts
Outdated
| @@ -1,5 +1,6 @@ | |||
| import { HTLCAttempt } from '../generated/rpc_pb'; | |||
There was a problem hiding this comment.
Do not import from generated types
src/types/rpc/router-rpc.ts
Outdated
| } | ||
|
|
||
| export interface PaymentStatusUpdate { | ||
| export interface PaymentStatus { |
There was a problem hiding this comment.
This was called PaymentStatusUpdate to avoid changing the PaymentStatus enum name
src/types/rpc/ln-rpc.ts
Outdated
| amt: number; | ||
| chanPoint?: ChannelPoint; | ||
| localKey?: KeyDescriptor; | ||
| remoteKey?: Uint8Array | string; |
There was a problem hiding this comment.
Uint8Array | string; -> Buffer | string;
src/types/rpc/ln-rpc.ts
Outdated
| chanPoint?: ChannelPoint; | ||
| localKey?: KeyDescriptor; | ||
| remoteKey?: Uint8Array | string; | ||
| pendingChanId?: Uint8Array | string; |
There was a problem hiding this comment.
Uint8Array | string; -> Buffer | string;
src/types/rpc/ln-rpc.ts
Outdated
| finalCltvDelta?: number; | ||
| feeLimit?: FeeLimit; | ||
| ignoredNodes?: Buffer[] | string[]; | ||
| ignoredEdges?: EdgeLocator[]; | ||
| sourcePubKey?: string; | ||
| useMissionControl?: boolean; | ||
| ignoredPairs?: NodePair[]; | ||
| cltvLimit?: number; | ||
| destCustomRecordsMap?: Array<[number, Uint8Array]> | string[]; |
There was a problem hiding this comment.
Array<[number, Uint8Array]> | string[]; -> Array<[number, Buffer]> | string[];
src/types/rpc/router-rpc.ts
Outdated
| cltvLimit?: number; | ||
| routeHints?: RouteHint[]; | ||
| destTlvMap?: Array<[number, Buffer | string]>; | ||
| destCustomRecordsMap?: Array<[number, Uint8Array]> | string[]; |
There was a problem hiding this comment.
Array<[number, Uint8Array]> | string[]; -> Array<[number, Buffer]> | string[];
|
The ln-rpc types are missing some new RPC methods & types: |
|
Updated! |
src/types/rpc/ln-rpc.ts
Outdated
| * the client in which any events relevant to the state of peers are sent | ||
| * over. Events include peers going online and offline. | ||
| */ | ||
| subscribePeerEvents(PeerEventSubscription): Promise<PeerEvent>; |
There was a problem hiding this comment.
This is a streaming method. The return type should be Readable<PeerEvent>
There was a problem hiding this comment.
Also the param should args?: {}
src/types/rpc/ln-rpc.ts
Outdated
| * Alternatively, this can be used to interactively drive PSBT signing for | ||
| * funding for partially complete funding transactions. | ||
| */ | ||
| fundingStateStep(FundingTransitionMsg): Promise<FundingStateStepResp>; |
There was a problem hiding this comment.
Param should be args?: FundingTransitionMsg
|
Remove package-lock.json |
|
Any subscription method names will have to be added to the correct |
|
Good call, I didn't realize that about the streaming methods. Updated with feedback. |
|
Updated with some props that were removed accidentally in previous commits. |
Adds support for lnd v0.9.0