Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Bump nightly toolchain #156

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

ci: Bump nightly toolchain #156

wants to merge 2 commits into from

Conversation

Rahix
Copy link
Owner

@Rahix Rahix commented May 4, 2024

Use the same version that is now used by avr-hal.

Rahix added 2 commits May 4, 2024 22:57
Use the same version that is now used by avr-hal.
@Rahix
Copy link
Owner Author

Rahix commented May 4, 2024

Hm, so we are running into Rahix/avr-hal#537 here as well now. I'm considering whether going "nuclear" and just pinning proc-macro2 for avr-device-macros directly might be the best solution:

diff --git a/macros/Cargo.toml b/macros/Cargo.toml
index 617e80b..5c3ece9 100644
--- a/macros/Cargo.toml
+++ b/macros/Cargo.toml
@@ -17,7 +17,7 @@ proc-macro = true
 
 [dependencies]
 quote = "1.0.7"
-proc-macro2 = "1.0.19"
+proc-macro2 = "=1.0.79"
 
 [dependencies.syn]
 version = "1.0.35"

Please voice your opinions...

@Rahix
Copy link
Owner Author

Rahix commented May 5, 2024

A downside of pinning in avr-device-macros is that downstream users cannot easily override it, I think. This means that when people want to switch to a different toolchain version, they can't adjust the proc-macro2 pin to work alongside it... Unfortunate :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant