Drop custom Peripherals
structs and RawPeripheral
newtype wrapper
#152
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sadly it seems this approach is not going to work well, so we will have to follow a different route. Already, the following problems are showing prominently:
Peripherals
struct, we need to manually add fields for all peripherals of all MCUs we support. This is not going to scale well.Peripherals
will look differently, this is going to look very confusing.Going back to the svd2rust generated
Peripherals
only, we also have to drop theRawPeripheral
newtype. I tried different solutions here and just dropping it entirely does seem to be the best looking. Instead, I added a special type-parameter inavr-hal-generic
with the sole purpose of circumventing the orphan rule which seems to work out quite nicely. See commit 9c33514 for details.