Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-implementation of the ADC HAL and support for all MCUs in
atmega-hal
. Also addressed issue #33 already.Notably, I dropped the implementation of the embedded-hal ADC traits for now. As discussed in #33 they are currently unfit for the purpose and instead of bending over backwards, I dropped them with the intention to re-add an implementation once embedded-hal hits 1.0.
Downstream code will look like this now: