Add refactored support for Arduino Diecimila #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Rahix should I move existing examples or follow basic set - like in e.g Leonardo? |
Rahix
requested changes
Apr 23, 2021
There was a problem hiding this comment.
Looks good, apart from one typo I spotted :) Thanks a lot! I don't have such a board either, so let's just hope for the best... Maybe @kallemooo who originally submitted Diecimila support can run tests?
42 tasks
explicite
commented
Apr 24, 2021
|
PWM example need to be done after PWM refactor. |
Rahix
approved these changes
Apr 24, 2021
Comment on lines
+172
to
+175
| programmer: "arduino", | ||
| partno: "atmega168", | ||
| baudrate: Some(19200), | ||
| do_chip_erase: false, |
There was a problem hiding this comment.
We can't verify those settings, can we? :/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for Diecimila