Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generic: adc: Move mega-specific code into atmega-hal #203

Merged
merged 1 commit into from
Jul 28, 2021
Merged

generic: adc: Move mega-specific code into atmega-hal #203

merged 1 commit into from
Jul 28, 2021

Conversation

quentinmit
Copy link
Contributor

Part one of #202

@quentinmit quentinmit mentioned this pull request Jul 28, 2021
Merged
Rahix
Rahix approved these changes Jul 28, 2021
View reviewed changes
Copy link
Owner

@Rahix Rahix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, thank you very much :) The only thing I noticed is that the ClockDivider type is still part of avr-hal-generic, but I suppose that's okay until a device pops up with less or more supported settings. So let's keep it as is.

@Rahix Rahix changed the title Refactor avr-hal-generic to move mega-specific code into atmega-hal generic: adc: Move mega-specific code into atmega-hal Jul 28, 2021
@Rahix Rahix merged commit 9698833 into Rahix:main Jul 28, 2021
@quentinmit quentinmit deleted the adc-refactor branch July 29, 2021 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rahix Rahix Rahix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@quentinmit @Rahix