Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add atmega328pb as a extension to atmega328p #96

Merged
merged 1 commit into from
Oct 29, 2020
Merged

Add atmega328pb as a extension to atmega328p #96

merged 1 commit into from
Oct 29, 2020

Conversation

jkristell
Copy link
Contributor

@jkristell jkristell commented Oct 26, 2020

I think it makes sense to make atmega328pb a "feature" of atmega328p. And it looks okayish this way. We could tweak the the device a bit so that the first i2c and spi device doesn't have a 0-suffix so that the second device would just be an addition, like for the Usart.

Remarks and questions

  • This depends on the Spi macro fix in Remove type defines #95
  • And I noticed I have a couple of todos left in the timer setup I need to take a look at.
  • Is there a clever way to select just one of the devices from avr-device?

@jkristell jkristell marked this pull request as ready for review October 27, 2020 08:26
@jkristell
Copy link
Contributor Author

As always, Only compile tested :-)

@Rahix Rahix added the mcu-support Support for a new Microcontroller label Oct 28, 2020
@Rahix Rahix mentioned this pull request Oct 28, 2020
Copy link
Owner

@Rahix Rahix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now! Thanks for working on this!

@jkristell
Copy link
Contributor Author

Did a rebase to clean up the history. I think this could be merged now. Thanks for all your patience with this unexpectedly complicated add of a device :)

@Rahix
Copy link
Owner

Rahix commented Oct 29, 2020

Did a rebase to clean up the history.

Much appreciated! I've given up asking people to do it by now ...

@Rahix Rahix merged commit 9f9d697 into Rahix:master Oct 29, 2020
@jkristell
Copy link
Contributor Author

Thanks for the merge. Github should add the squash feature that gitlab has, that's really handy.

Also want you to know that this is actually tested on hardware now, and the things I tested so far works great. You have done a fantastic job with all of the avr-crates. Thanks!

@jkristell jkristell deleted the add-atmega328pb-to-atmega328p branch November 3, 2020 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mcu-support Support for a new Microcontroller
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants