Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhanced the UI of Temperature Calculator #1746

Merged
merged 8 commits into from
Aug 8, 2024
Merged

Enhanced the UI of Temperature Calculator #1746

merged 8 commits into from
Aug 8, 2024

Conversation

vansh-codes
Copy link
Contributor

@vansh-codes vansh-codes commented Jul 31, 2024 •
edited by Rakesh9100
Loading

Fixes Issue🛠️

Closes #1550

Description👨‍💻

  • Enhanced the UI in terms of both UI and UX
  • Changed logic:
    • when selected celsius, disabled the celsius in the convert from menu and this applies to all menus
    • when submitted once, is user selects any other radio option, the result is dynamically updated, user doesnt need to press submit again
    • added debouncing to minimize the function call for dynamic updates of selection

Type of Change📄

  • Style (non-breaking change which improves website style or formatting)

Checklist✅

  • I am an Open Source contributor
  • I have performed a self-review of my code
  • My code follows the style guidelines of this project

Screenshots/GIF📷

BEFORE

image

AFTER

image

Screen.Recording.2024-07-31.233957.mp4

github-actions[bot]
github-actions bot reviewed Jul 31, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @vansh-codes, Welcome to the project CalcDiverse! 🎊
Thanks for your contribution! Your effort makes this project better. Keep it up! 🙌
Please wait for the PR to be reviewed. Happy Coding!! ✨

@vansh-codes vansh-codes changed the title Enhanced the UI of Temperature Calculator Enhanced the UI of Temperature Calculator and enhanced the 'logic/script' Jul 31, 2024
@Rakesh9100
Copy link
Owner

The result should be displayed above the submit button with a message like '100 degree celcius is 212 Fahreneits'

You have mentioned this change to be done in the issue, but it is not done @vansh-codes

@Rakesh9100 Rakesh9100 added the question 🤔 Further information is requested label Aug 3, 2024
@Rakesh9100 Rakesh9100 changed the title Enhanced the UI of Temperature Calculator and enhanced the 'logic/script' Enhanced the UI of Temperature Calculator Aug 3, 2024
@netlify Netlify
Copy link

netlify bot commented Aug 4, 2024 •
edited
Loading

✅ Deploy Preview for calcdiverse ready!

Name Link
🔨 Latest commit e94b1c2
🔍 Latest deploy log https://app.netlify.com/sites/calcdiverse/deploys/66b5029b7b31650008ff25d6
😎 Deploy Preview https://deploy-preview-1746--calcdiverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vansh-codes
Copy link
Contributor Author

@Rakesh9100 Did the required changes. Please review. Heres a screenshot for reference:
image

@vansh-codes
Copy link
Contributor Author

@Rakesh9100 Please review, I have made the mentioned changes

@vansh-codes vansh-codes mentioned this pull request Aug 8, 2024
Closed
7 tasks
@vansh-codes
Copy link
Contributor Author

@Rakesh9100 Please merge this PR so that I can create PR's for other issues assigned to me

@Rakesh9100 Rakesh9100 merged commit ea0a179 into Rakesh9100:main Aug 8, 2024
4 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024

Congrats, Your pull request has been successfully merged 🥳🎉 Thank you for your contribution to my project 🚀 Keep Contributing!! ✨ @vansh-codes

@Rakesh9100 Rakesh9100 added Completed 🥳 PR successfully merged and issue resolved on completion gssoc GSSoC 2k24 Open Source Program level3 GSSoC2k24 Level-3 Task -- 45 Points and removed question 🤔 Further information is requested labels Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees

@vansh-codes vansh-codes

Labels
Completed 🥳 PR successfully merged and issue resolved on completion gssoc GSSoC 2k24 Open Source Program level3 GSSoC2k24 Level-3 Task -- 45 Points
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Style] Enhance the UI of Temperature Calculator
2 participants
@vansh-codes @Rakesh9100