Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Neon Number Calculator #574

Merged
merged 5 commits into from
Feb 11, 2024
Merged

Added Neon Number Calculator #574

merged 5 commits into from
Feb 11, 2024

Conversation

AftabMankapure
Copy link
Contributor

@AftabMankapure AftabMankapure commented Feb 9, 2024 •
edited by Rakesh9100
Loading

Fixes Issue🛠️

Closes #520

Description👨‍💻

Added new calculator to check and find neon number in range.

Type of change📄

  • New feature (non-breaking change which adds functionality)

Checklist✅

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added demonstration in the form of GIF/video file
  • I am an Open Source Contributor

Screenshots/GIF📷

Neon

@netlify Netlify
Copy link

netlify bot commented Feb 9, 2024 •
edited
Loading

✅ Deploy Preview for calcdiverse ready!

Name Link
🔨 Latest commit 41c8d53
🔍 Latest deploy log https://app.netlify.com/sites/calcdiverse/deploys/65c89f1c0cf5dd0008df8dbf
😎 Deploy Preview https://deploy-preview-574--calcdiverse.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot]
github-actions bot reviewed Feb 9, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @AftabMankapure, Welcome to the project CalcDiverse! 🎊
Thanks for your contribution! Your effort makes this project better. Keep it up! 🙌
Please wait for the PR to be reviewed. Happy Coding!! ✨

@AftabMankapure
Copy link
Contributor Author

pls check this PR

@Rakesh9100 Rakesh9100 changed the title added neon number calculator Added Neon Number Calculator Feb 10, 2024
@Rakesh9100
Copy link
Owner

Let suppose I entered number 100 and clicked on Check, it is displaying 100 is not a Neon number. The square of 100 is 10000. The sum of its digits is 1.

But for 9, it is just showing 9 is a Neon number. It should display how it is neon @AftabMankapure

@Rakesh9100 Rakesh9100 added the question 🤔 Further information is requested label Feb 10, 2024
@AftabMankapure
Copy link
Contributor Author

check now

@AftabMankapure
Copy link
Contributor Author

ne

@Rakesh9100
Copy link
Owner

0 is also Neon but it is showing to enter a valid positive integer, fix it @AftabMankapure

@AftabMankapure
Copy link
Contributor Author

n1

@Rakesh9100
Copy link
Owner

Merged 🎉 @AftabMankapure

@Rakesh9100 Rakesh9100 merged commit 9e6d47e into Rakesh9100:main Feb 11, 2024
4 checks passed
@Rakesh9100 Rakesh9100 added Completed 🥳 PR successfully merged and issue resolved on completion Medium IWOC2k24 (30 Points) ✨, JWOC2k24 (3 Points) 🎉, SWOC2k24 Level-2 (30 Points) 💫 JWOC JWOC 2k24 Open Source Program and removed question 🤔 Further information is requested labels Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees

@AftabMankapure AftabMankapure

Labels
Completed 🥳 PR successfully merged and issue resolved on completion JWOC JWOC 2k24 Open Source Program Medium IWOC2k24 (30 Points) ✨, JWOC2k24 (3 Points) 🎉, SWOC2k24 Level-2 (30 Points) 💫
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Add Neon Number Calculator
2 participants
@AftabMankapure @Rakesh9100