Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve examples in README #21

Merged
merged 5 commits into from
Nov 27, 2018
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ RUN buildDeps=' \
\
&& curl -fsSL ${url}.asc -o ${tmpdir}/rakudo.tar.gz.asc \
&& curl -fsSL $url -o ${tmpdir}/rakudo.tar.gz \
&& gpg --keyserver $keyserver --recv-keys $keyfp \
&& gpg --batch --verify ${tmpdir}/rakudo.tar.gz.asc ${tmpdir}/rakudo.tar.gz \
&& gpg --no-tty --keyserver $keyserver --recv-keys $keyfp \
&& gpg --no-tty --batch --verify ${tmpdir}/rakudo.tar.gz.asc ${tmpdir}/rakudo.tar.gz \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be just --batch on both lines (no need for --no-tty with --batch).

See https://bugs.debian.org/913614 and all the linked things on docker-library/busybox#55 for more information.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tianon could we also just inline the GPG pubkey here (and avoid using keyserver for this altogether?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed, and we still have the error.

\
&& tar xzf ${tmpdir}/rakudo.tar.gz --strip-components=1 -C ${tmpdir}/rakudo \
&& ( \
Expand Down
12 changes: 4 additions & 8 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,21 +32,17 @@ you use the default version.

Simply running a container with the image will launch a Perl 6 REPL:

$ docker run -it rakudo-star
$ docker run --rm -it rakudo-star
zakame marked this conversation as resolved.
Show resolved Hide resolved
> say 'Hello, Perl!'
Hello, Perl!

You can also provide perl6 command line switches to `docker run`:

$ docker run -it rakudo-star perl6 -e 'say "Hello!"'
$ docker run --rm rakudo-star perl6 -e 'say "Hello!"'
zakame marked this conversation as resolved.
Show resolved Hide resolved

In addition, you can mount a directory from the host within a container:
In addition, you can run a script located in the current folder:

$ docker run -it -v $HOME/my_p6_projects/:/mount_location/ rakudo-star /bin/bash

Then, you can run your scripts from inside the container:

# perl6 /mount_location/my_p6_script.p6
$ docker run --rm -v "$(pwd):/script" rakudo-star perl6 /script/my_p6_script.p6

# Contributing/Getting Help

Expand Down