Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test-docker-image.yml: Update actions/checkout to v4 and... #61

Merged
merged 3 commits into from
Apr 2, 2024
Merged

test-docker-image.yml: Update actions/checkout to v4 and... #61

merged 3 commits into from
Apr 2, 2024

Conversation

AntonOks
Copy link
Collaborator

make the "ls" command, which lists the "Rakudo" version directory, more explicit

Copy link
Contributor

@JJ JJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a major problem with this; unfortunately, adding switches to something that apparently works correctly needs to justify the value it adds. As in your other pr, upgrading the checkout action seems reasonable enough, I'd go for that.

.github/workflows/test-docker-image.yml Show resolved Hide resolved
@AntonOks
Copy link
Collaborator Author

I don't see a major problem with this; unfortunately, adding switches to something that apparently works correctly needs to justify the value it adds. As in your other pr, upgrading the checkout action seems reasonable enough, I'd go for that.

I'm ok with leaving it as it is... I just thought, its easier / better to understand for someone, looking into this "code" (we look for a specific directory.... what if a plain file with a similar name would appear somehow ;) )...

@AntonOks AntonOks requested a review from JJ April 1, 2024 21:02
Copy link
Contributor

@JJ JJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@JJ JJ merged commit aa61dfd into Raku:master Apr 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants