Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nqp::split should allow for boxing type #713

Open
lizmat opened this issue Apr 10, 2021 · 1 comment
Open

nqp::split should allow for boxing type #713

lizmat opened this issue Apr 10, 2021 · 1 comment

Comments

@lizmat
Copy link
Contributor

lizmat commented Apr 10, 2021

Or is should just return an nqp::list_s rather than an nqp::list with boxed strings.

nqp::split is documented to take 2 parameters: the delimiter and the string. It can actually take a third parameter, of which the usage is undocumented (and I've not been able to find a usage of in the NQP code base).

@MasterDuke17
Copy link
Contributor

nqp::split is documented to take 2 parameters: the delimiter and the string. It can actually take a third parameter, of which the usage is undocumented (and I've not been able to find a usage of in the NQP code base).

If #714 is merged then nqp::split won't accept a third parameter anymore (in fact no ops will accept as a write destination, one more parameter than they're documented with).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants