Disallow explicity specifying op write registers #714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ability isn't used in NQP or Rakudo, and can cause confusion. E.g.,
`for nqp::split(",", "abc,def", "ghasdfi") { say($_) }` before would
print "ghasdfi", now it dies with `Arg count 3 doesn't equal required
operand count 2 for op 'split'`.
jnthn
approved these changes
Apr 16, 2021
MasterDuke17
deleted the
no_longer_allow_explicitly_specifying_write_register_for_ops
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ability isn't used in NQP or Rakudo, and can cause confusion. E.g.,
for nqp::split(",", "abc,def", "ghasdfi") { say($_) }before wouldprint "ghasdfi", now it dies with
Arg count 3 doesn't equal required operand count 2 for op 'split'.NQP builds ok and passes
make m-testand Rakudo builds ok and passesmake m-test m-spectest.