Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Panic when given empty character class <[ ]> #435

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jstuder-gh
Copy link
Contributor

Description:
Check whether the QAST node has any children to determine if it is
empty. The exception are the backslash cclass nodes (\b, \n, \s, etc).

When providing a fix for Rakudo Issue 1622, there was some discussion about whether the empty character class should be allowed at all (see discussion here).

Should this panic behavior be adopted as part of the official behavior of Perl 6 in future releases (6.d+) despite it being somewhat at odds with the behavior detailed in the roast before?

Check whether the QAST node has any children to determine if it is
empty.  The exception are the backslash cclass nodes (\b, \n, \s, etc).
@JJ
Copy link
Contributor

JJ commented Jan 18, 2023

Is there any point in keeping these PRs here? Can they be salvaged/closed? First thing would be; I guess, to rebase to current main branch, right?

@lizmat
Copy link
Contributor

lizmat commented Jan 18, 2023

Good question. I propose we look at all of the PRs in NQP / Rakudo again after RakuAST is fully integrated. It's too much of a shifting landscape at the moment, I'd say.

@coke coke changed the base branch from master to main April 19, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants