Skip to content

Commit

Permalink
Rollup merge of #131358 - onur-ozkan:129528, r=Mark-Simulacrum
Browse files Browse the repository at this point in the history
force "HEAD" for non-CI and `git_upstream_merge_base` for CI environment

When rust-lang/rust is configured as remote, some of the git logic (for tracking changed files) that uses get_closest_merge_commit starts to produce annoying results as the upstream branch becomes outdated quickly (since it isn't updated with git pull). We can rely on HEAD for non-CI environments as we specifically treat bors commits as merge commits, which also exist on upstream. As for CI environments, we should use `git_upstream_merge_base` to correctly track modified files as bors commits may be in `HEAD` but not yet on the upstream remote.

This is also an alternative fix for rust-lang/rust#129528 since rust-lang/rust#131331 reverts the previous fix attempts.
  • Loading branch information
tgross35 authored Oct 13, 2024
2 parents c594bdb + fc7db14 commit bdb6937
Showing 0 changed files with 0 additions and 0 deletions.

0 comments on commit bdb6937

Please sign in to comment.