go.mod: add replace directive for the k8s.io packages #1099
Conversation
Some of the modules we depend on are still using k8s.io/kubernetes module which is discouraged by the kubernetes maintainers. It also leads to errors when you run a go get command to add or update a go module. Adding these replace directives will let the go tools know how to workaround the problem. This commit doesn't change any of the dependencies. Signed-off-by: Raghavendra Talur <[email protected]>
|
Fixes #958 |
raghavendra-talur
requested review from
nirs,
rakeshgm,
ShyamsundarR and
BenamarMk
|
Based on argoproj/argo-cd#4055 (comment) the issue is in gitops-engine - can we fix it there instead? |
I tried to do that but it doesn't look easy. They are using some of the modules that aren't available in the k8s.io org anywhere except k8s.io/kubernetes. And they have concerns about performance if they have to give up using these modules. You can see some of the previous attempts by others at I would also prefer a cleaner fix by fixing it at the source, but it has been open for too long and not being able to run a simple |
There was a problem hiding this comment.
Having to deal with go get failures fixing this is useful. @nirs the current alternative seems to be to do this, although being fixed at the source would have been better.
Some of the modules we depend on are still using k8s.io/kubernetes module which is discouraged by the kubernetes maintainers.
It also leads to errors when you run a go get command to add or update a go module. Adding these replace directives will let the go tools know how to workaround the problem. This commit doesn't change any of the dependencies.