VRG: Add multi StorageClasses support by filtering PeerClasses #1487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
rakeshgm
commented
Jul 18, 2024
rakeshgm
commented
- Filter PeerClasses in VRG based on sync and async, finalise the selection of replicationClass and snapshotClass from the list of peerClasses.
- wip: fix unit tests
rakeshgm
force-pushed
the
vrg-peerclass-spec
branch
2 times, most recently
from
9157b6a
to
94b9e4c
Compare
rakeshgm
force-pushed
the
vrg-peerclass-spec
branch
8 times, most recently
from
6c768fd
to
8a71d34
Compare
rakeshgm
force-pushed
the
vrg-peerclass-spec
branch
5 times, most recently
from
792e99a
to
6faa41a
Compare
rakeshgm
force-pushed
the
vrg-peerclass-spec
branch
6 times, most recently
from
c97a818
to
ac13d94
Compare
Signed-off-by: rakeshgm <[email protected]>
introduced PeerClasses field under spec.Async and spec.Sync. this contains replciation id, storage id and StorageClassName. Signed-off-by: rakeshgm <[email protected]>
Signed-off-by: rakeshgm <[email protected]>
improve filtering replicationClass Signed-off-by: rakeshgm <[email protected]>
add StorageClass Labels, ReplicationClass Lables and PeerClasses Signed-off-by: rakeshgm <[email protected]>
add StorgeClass Label, VolumeSnapshotClass Labels and PeerClasses Signed-off-by: rakeshgm <[email protected]>
Signed-off-by: rakeshgm <[email protected]>
Signed-off-by: rakeshgm <[email protected]>
adding tests with no peerClasses and no replicaitonID in VRC Signed-off-by: rakeshgm <[email protected]>
rakeshgm
force-pushed
the
vrg-peerclass-spec
branch
from
ac13d94
to
b27af18
Compare
skip filtering using sid with replicationClass if peerclass is not found Signed-off-by: rakeshgm <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.