kubeobjects: disable hooks #1533
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raghavendra-talur
force-pushed
the
rtalur-disable-hooks
branch
from
c5fd7ec
to
95fbf66
Compare
So far, we don't have the ability to run hooks specified in a recipe. We were wrongly passing these hooks to velero in the capture or recover spec. This commit disables the hooks completely by skipping them. In a later PR, we will add the ability to run the hooks in the recipe natively in Ramen. Signed-off-by: Raghavendra Talur <[email protected]>
raghavendra-talur
force-pushed
the
rtalur-disable-hooks
branch
from
95fbf66
to
6e0a45b
Compare
raghavendra-talur
requested review from
asn1809,
ShyamsundarR,
nirs,
ELENAGER,
BenamarMk and
rakeshgm
|
Fixes #1544 |
ShyamsundarR
approved these changes
Sep 6, 2024
Why passing the hook to velero is wrong? https://github.com/RamenDR/ramen/blob/main/docs/recipe.md does not specify how hooks should run. Maybe start this work by updating the doc to explain the desired behavior? |
|
@raghavendra-talur the envtest failure seems genuine as it is a hook test is some different namespace. As hooks are disabled here, that test will not pass and needs to be removed or disabled. |
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, we don't have the ability to run hooks specified in a recipe. We
were wrongly passing these hooks to velero in the capture or recover
spec.
This commit disables the hooks completely by skipping them. In a later
PR, we will add the ability to run the hooks in the recipe natively in
Ramen.