Additional changes for lima #1555
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirs
force-pushed
the
lima-flannel
branch
3 times, most recently
from
4dd76ad
to
ce3b880
Compare
nirs
changed the title
nirs
force-pushed
the
lima-flannel
branch
2 times, most recently
from
8260598
to
affecd7
Compare
Change taken from k8s-lima repo[1]. In my tests it does not make any difference, posting for testing on other system. [1] https://github.com/raghavendra-talur/k8s-lima Thanks: Raghavendra Talur <[email protected]> Signed-off-by: Nir Soffer <[email protected]>
Enable the option for iptables[1] and nftables[2]. I'm not sure which one we use but it does not harm to change the one we don't use. Change taken from k8s-lima repo[3]. In my tests it does not make any difference, posting for testing on other system. [1] https://kubernetes.io/docs/reference/config-api/kube-proxy-config.v1alpha1/#kubeproxy-config-k8s-io-v1alpha1-KubeProxyIPTablesConfiguration [2] https://kubernetes.io/docs/reference/config-api/kube-proxy-config.v1alpha1/#kubeproxy-config-k8s-io-v1alpha1-KubeProxyNFTablesConfiguration [3] https://github.com/raghavendra-talur/k8s-lima Thanks: Raghavendra Talur <[email protected]> Signed-off-by: Nir Soffer <[email protected]>
Change taken from k8s-lima repo[1]. In my tests it does not make any difference, posting for testing on other system. [1] https://github.com/raghavendra-talur/k8s-lima Thanks: Raghavendra Talur <[email protected]> Signed-off-by: Nir Soffer <[email protected]>
|
Seems that we don't need this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change include 3 changes from k8s-lima repo that seems unneeded in my tests. Posting them for testing on other systems.