Fix #899 auto scroll set to start closes move description. #927
Conversation
|
I don't really like this fix. Disabling autoscroll out of the blue feels inconsistent and confusing UI-wise. What do others think? |
|
There might be a better way to do this. I have a limited knowledge of gbc asm and it's inner workings. I was trying to help out with some cosmetic minor issues. From my understanding it uses the stack to save the autoscroll setting value and then disables it for the one time showing of the move text and pops the stack to retrieve the old value. My other thoughts to solve would be to check a flag or something for the specific use case of showing the move description or something. Again, there may be a more performant, less memory intensive way. I wanted to help out where I could so feedback is appreciated. Let me know how I can help |
No description provided.