Skip to content
This repository has been archived by the owner on Jul 1, 2024. It is now read-only.

add parametric model #45

Merged
merged 28 commits into from
Mar 9, 2024
Merged

add parametric model #45

merged 28 commits into from
Mar 9, 2024

Conversation

RaphaelS1
Copy link
Owner

@RaphaelS1 RaphaelS1 commented Mar 1, 2024

@bblodfon if you could help tick off this list that would be very helpful to get this over the line

@RaphaelS1 RaphaelS1 changed the title add parametic model add parametric model Mar 1, 2024
@RaphaelS1 RaphaelS1 requested a review from bblodfon March 5, 2024 09:43
@RaphaelS1
Copy link
Owner Author

@bblodfon tests now passing, please review when you have time

@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 96.84211% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 35.40%. Comparing base (9d59b0c) to head (feb9476).
Report is 8 commits behind head on main.

Files Patch % Lines
R/parametric.R 97.15% 5 Missing ⚠️
R/methods.R 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              main      #45       +/-   ##
============================================
- Coverage   100.00%   35.40%   -64.60%     
============================================
  Files           16       18        +2     
  Lines          780      983      +203     
============================================
- Hits           780      348      -432     
- Misses           0      635      +635     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

R/parametric.R Outdated Show resolved Hide resolved
R/parametric.R Outdated Show resolved Hide resolved
R/parametric.R Outdated Show resolved Hide resolved
@RaphaelS1 RaphaelS1 merged commit 0344750 into main Mar 9, 2024
2 of 3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants