Master

src/Data/VariableCollection.php

@@ -29,7 +29,7 @@ public function toArray(): array
                 default => StringType::class,
             };
 
-            $variables[$key] = (new $typeClass())($value);
+            $variables[$key] = (new $typeClass)($value);
         }
 
         return $variables;

src/Http/ExternalTaskClient.php

@@ -67,15 +67,20 @@ public static function getTaskLocked(): array
     public static function fetchAndLock(string $workerId, array $topics, int $maxTasks = 10): array
     {
         $payload = ['workerId' => $workerId, 'maxTasks' => $maxTasks, 'topics' => $topics];
-        $response = self::make()->post('external-task/fetchAndLock', $payload);
+        $url = 'external-task/fetchAndLock';
+        $response = self::make()->post($url, $payload);
 
-        $data = [];
-        if ($response->successful()) {
-            /** @var array<array> */
+        if (! $response->successful()) {
+            /** @var array */
             $array = $response->json();
-            foreach ($array as $task) {
-                $data[] = ExternalTaskData::fromArray($task);
-            }
+            throw (new UnexpectedResponseException)->for($url, $payload, $array);
+        }
+
+        $data = [];
+        /** @var array<array> */
+        $array = $response->json();
+        foreach ($array as $task) {
+            $data[] = ExternalTaskData::fromArray($task);
         }
 
         return $data;
@@ -113,7 +118,6 @@ public static function fail(
         string $errorMessage = 'Does not compute',
         int $retryTimeout = 60000,
     ): bool {
-
         $payload = compact('workerId', 'errorMessage', 'retryTimeout');
         $url = "external-task/$id/failure";
         $response = self::make()->post($url, $payload);

src/Http/TaskHistoryClient.php

@@ -29,8 +29,7 @@ public static function find(string $id): TaskHistoryData
         }
 
         /** @var string */
-        $message = $response->json('message');
-
+        $message = $response->json('message') ?? $response->body();
         throw new CamundaException($message);
     }