Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TypeError on missing shard_id kwarg #4166

Merged
merged 2 commits into from
Jun 7, 2020
Merged

Fix TypeError on missing shard_id kwarg #4166

merged 2 commits into from
Jun 7, 2020

Conversation

anurag-7
Copy link
Contributor

@anurag-7 anurag-7 commented Jun 1, 2020

Summary

This PR fixes TypeError raised when chunker method is missing shard_id keyword-only argument in _chunk_and_dispatch for AutoShardedConnectionState.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@Taarek Taarek mentioned this pull request Jun 4, 2020
Closed
7 tasks
@Rapptz
Copy link
Owner

Rapptz commented Jun 5, 2020

Probably better to fix this at the signature level.

@anurag-7
Copy link
Contributor Author

anurag-7 commented Jun 5, 2020

Changed chunker's Signature and definition to handle the issue.

@Rapptz Rapptz merged commit 421d8bf into Rapptz:master Jun 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anurag-7 @Rapptz