Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Polls #9759
Add support for Polls #9759
Changes from 76 commits
86f9860
fd5c37a
f0eca90
7cb5911
c660a7e
5e58841
263b7a1
523faca
1d9bd58
b086bae
e670095
e6151d6
0c12a53
51a2e0f
1cadca0
9f3ddc9
85cdffc
07b21db
0a61840
e895389
9d6ad95
74c8efc
3444f80
6c7c49b
b9f74d8
09f5437
cba11b6
9bf1c3d
a5514e1
0a38090
27bc8c7
89c3501
c0ca0fd
03e3ef0
96dfd72
4094bf9
ca155da
824b003
7456255
cd821a0
1e9a1f6
c4f9951
d3cc82b
7637d93
f7462ae
cca6f9b
ddefc1f
8989529
0419f3d
c66bc51
b754635
9193f70
bd1e203
11f42ca
87e583d
d190bfb
aadaea6
4ef2222
2410fed
c48a24c
a4126c8
f4edabc
e687146
aa75030
648ada7
9ea8df2
618658f
0dfb675
3258c32
8bf15cf
fab8524
9860f35
5253697
f877b54
fda6135
a96a6e2
1253761
c3de7c9
8c6ed29
e5b6468
7170a04
0541527
c246e8e
f50456c
b091943
c621992
9583e84
de1947a
b3f753a
a9bcf4a
3db12c1
8b74a1a
20f33a8
1f1edeb
028899b
8a1ebf9
84be92c
2f9b9c4
635f69c
d93954f
f118958
c4d9cc5
127a212
a4a9e0e
8ff203d
7396cb8
ce37704
def3d76
cc8d9d4
6f64ab8
3f0c5dd
63a3fd6
1bd623c
2bae4a0
fac840e
5f4ba13
f2c4cdb
09a4c59
a24f1b0
f17546f
8a49c88
ef3b685
2df6f0d
c81261f
cc01fff
082a1b9
065abab
bc41755
e904668
b74d2a5
0093e66
ded24b0
022e511
26f39be
b83f7e0
f34f400
b9a8da3
4ead3f2
4ac3dcf
807a72f
004cefc
be53f23
6a5e306
e881dc7
7038423
c68ae70
7e427bc
ee1250f
98eda87
7940d43
63b65d4
78d8c70
d964851
492751e
c941cad
7a174e3
ca8ca38
91134e8
e4d41bf
41151c2
dfb124a
82bb213
deb19f3
6b0374a
d952eae
8b2515e
cbfcd15
cdadbb1
e120721
2a6c4ea
0138dca
8fbce83
8adaf0f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure there's much benefit to having the library validate this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to reiterate this, I'm still not sure we should be doing this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct, the library delegates this stuff to the server side since it's the source of truth. It only validates when the trade-off for user experience is better (e.g.
discord.ui
). This is not true for polls to me.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.