Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use tpl for extraEnvs for app deployment #156

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Gazler
Copy link

@Gazler Gazler commented Mar 5, 2021

For a custom actions server, it can be desirable to leverage variables
defined in the values, for example something like:

app:
    extraEnvs:
       - name: "RASA_FULLNAME"
         value: "{{ include \"rasa-x.fullname\" . }}

To allow this, extraEnvs are now iterated over with the tpl
function, so any template strings defined in values.yml are executed.

For a custom actions server, it can be desirable to leverage variables
defined in the values, for example something like:

```
app:
    extraEnvs:
       - name: "RASA_FULLNAME"
         value: "{{ include \"rasa-x.fullname\" . }}
```

To allow this, `extraEnvs` are now iterated over with the `tpl`
function, so any template strings defined in `values.yml` are executed.
@Gazler Gazler requested a review from a team as a code owner March 5, 2021 09:18
@Gazler Gazler requested review from tczekajlo and removed request for a team March 5, 2021 09:18
@Gazler
Copy link
Author

Gazler commented Mar 5, 2021

For reference, the use case I had required calling the rasa API from a custom action server, so I needed something like:

    extraEnvs:
       - name: "RASA_PRODUCTION_HOST"
         value: "{{ include \"rasa-x.fullname\" . }}-{{ .Values.rasa.versions.rasaProduction.serviceName }}.{{ .Release.Namespace }}.svc:{{ .Values.rasa.port }}"

@sara-tagger sara-tagger requested a review from amn41 March 5, 2021 13:00
@sara-tagger
Copy link

Thanks for submitting a pull request 🚀 @amn41 will take a look at it as soon as possible ✨

@tczekajlo tczekajlo removed the request for review from amn41 November 26, 2021 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants