-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flipped Objects part in book 2 (remove flip_face
class?)
#482
Comments
Yow. Excellent comment. A lot of work, but we didn't realize that we'd greatly simplified this part of the code. :) |
Putting this in the v3.1.0 milestone unless we decide otherwise. |
flip_face
class?)
I can also confirm that I was able to render cornell box without flip_face class and was quite surprised by not having the Empty Cornell box from listing 55. |
Note: see #270 for the original change that implemented proper ray-surface intersection from either side. |
raytracing.github.io/books/RayTracingTheNextWeek.html
Line 2054 in 5111229
I' ve noticed that we have already fliped the normal by
rec.set_face_normal
inhit
function, the filp class seems to be useless.We may either remove the set normal function inrect::hit
or remove the flip_face class.The text was updated successfully, but these errors were encountered: