Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update render 1.14 #559

Closed
hollasch opened this issue May 17, 2020 · 3 comments
Closed

Update render 1.14 #559

hollasch opened this issue May 17, 2020 · 3 comments
Assignees
Milestone

Comments

@hollasch
Copy link
Collaborator

hollasch commented May 17, 2020

  • Width 400 (× 225)
  • PNG format

Ref #179

@hollasch hollasch added this to the v3.2.0 milestone May 17, 2020
@hollasch hollasch self-assigned this May 17, 2020
@hollasch
Copy link
Collaborator Author

The source for this image is wrong somehow. It currently contains NaNs in the output, leading to a corrupted image.

Use the progression branch to get to a debuggable state.

@trevordblack
Copy link
Collaborator

Hunch:
it's cause of the lack of

double cos_theta = fmin(dot(-unit_direction, rec.normal), 1.0);

fmin

@hollasch
Copy link
Collaborator Author

hollasch commented May 30, 2020

In the progression branch, I added it (in the refract() function). No joy. Also made r_out_parallel a unit vector, but that didn't help. Added code to write out cyan for any NaN-containing color, and basically anything that touches glass gets a NaN result.

hollasch added a commit that referenced this issue May 31, 2020
hollasch added a commit that referenced this issue May 31, 2020
@hollasch hollasch closed this as completed Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants