Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

True up the nomenclature with the final code, which uses a switch statement with 10 different scene numbers. #620

Closed
trevordblack opened this issue May 24, 2020 · 4 comments

Comments

@trevordblack
Copy link
Collaborator

We should also true up the nomenclature with the final code, which uses a switch statement with 10 different scene numbers.

Originally posted by @hollasch in #325 (comment)

@trevordblack trevordblack self-assigned this May 24, 2020
@trevordblack trevordblack added this to the v3.2.0 milestone May 24, 2020
@trevordblack trevordblack removed their assignment May 24, 2020
@hollasch
Copy link
Collaborator

This is ongoing with the current progression task rolling through book 2.

@trevordblack
Copy link
Collaborator Author

With the exception of the explicit cornell_smoke as case 7:, the code in the source and the in-line source in text are very similar (after #643).
Close this issue?

@hollasch
Copy link
Collaborator

No, we need to get this synchronized. I'll re-render cornell_balls to see if it's a worthy image. If not, we can just remove it completely in the code. If it's useful, we'll add text to explain it. Similarly for cornell_final.

cornell_smoke just needs the case in the text.

@hollasch hollasch assigned hollasch and unassigned trevordblack Jun 24, 2020
@hollasch
Copy link
Collaborator

Ref #650, #653

hollasch added a commit that referenced this issue Jul 14, 2020
These were `cornell_balls` and `cornell_final`, two scenes not
referenced in the book.

Resolves #653
Resolves #620
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants