Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Book1 Listing 23: cstdlib is not necessary yet #687

Closed
estshorter opened this issue Aug 9, 2020 · 0 comments
Closed

Book1 Listing 23: cstdlib is not necessary yet #687

estshorter opened this issue Aug 9, 2020 · 0 comments
Assignees
@hollasch
Labels
book 1: One Weekend
Milestone
v3.2.1

Comments

@estshorter
Copy link
Contributor

estshorter commented Aug 9, 2020 •
edited
Loading

As rand() is not used at this stage, I think #include <cstdlib> can be removed.

raytracing.github.io/books/RayTracingInOneWeekend.html

Line 1186 in 7b92650

#include <cstdlib>

@hollasch hollasch self-assigned this Aug 9, 2020
hollasch added a commit that referenced this issue Aug 9, 2020
@hollasch
Remove unnecesary include of cstdlib
ba881d8 
It's not needed until we use the std `rand()` function.

Resolves #687
@hollasch hollasch added this to the v3.2.1 milestone Aug 9, 2020
@hollasch hollasch mentioned this issue Aug 9, 2020
Closed
hollasch added a commit that referenced this issue Aug 19, 2020
@hollasch
Remove premature include of cstdlib
f0f4d2a 
It's not needed until we use the `rand()` function.

Resolves #687
@hollasch hollasch mentioned this issue Aug 19, 2020
Merged
hollasch added a commit that referenced this issue Aug 19, 2020
@hollasch
Remove premature include of cstdlib
e5d64a1 
It's not needed until we use the `rand()` function.

Resolves #687
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hollasch hollasch

Labels
book 1: One Weekend
Projects
None yet
Milestone
v3.2.1
Development

No branches or pull requests
2 participants
@hollasch @estshorter