Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Book2: Listing 70: fuzz value and include bvh.h #694

Closed
estshorter opened this issue Aug 14, 2020 · 1 comment · Fixed by #708
Closed

Book2: Listing 70: fuzz value and include bvh.h #694

estshorter opened this issue Aug 14, 2020 · 1 comment · Fixed by #708
Assignees
@estshorter
Labels
area: book book 2: Next Week
Milestone
v3.2.1

Comments

@estshorter
Copy link
Contributor

estshorter commented Aug 14, 2020 •
edited
Loading

  • bvh.h should be included as it usesbvh_node.
  • Fuzz value for the metal sphere is set to 10.0, but 1.0 would be better, which is the maximum value.

raytracing.github.io/books/RayTracingTheNextWeek.html

Lines 3279 to 3281 in 7b92650

objects.add(make_shared<sphere>(
point3(0, 150, 145), 50, make_shared<metal>(color(0.8, 0.8, 0.9), 10.0)
));

raytracing.github.io/src/TheNextWeek/material.h

Line 60 in 7b92650

metal(const color& a, double f) : albedo(a), fuzz(f < 1 ? f : 1) {}

@hollasch hollasch self-assigned this Aug 18, 2020
@hollasch hollasch added this to the v3.2.1 milestone Aug 18, 2020
@hollasch hollasch removed their assignment Aug 20, 2020
@estshorter estshorter mentioned this issue Aug 21, 2020
Closed
@estshorter estshorter mentioned this issue Aug 22, 2020
Merged
@estshorter estshorter linked a pull request Aug 27, 2020 that will close this issue
Fix: Book2: Listing 70 (#694) #708
Merged
hollasch added a commit that referenced this issue Aug 27, 2020
@hollasch
Merge pull request #708 from estshorter/fix-issue-694
94753a6 
Fix: Book2: Listing 70 (#694)
@hollasch
Copy link
Collaborator

Fixed in #708

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@estshorter estshorter

Labels
area: book book 2: Next Week
Projects
None yet
Milestone
v3.2.1
Development

Successfully merging a pull request may close this issue.

Fix: Book2: Listing 70 (#694)
2 participants
@hollasch @estshorter