Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move method definitions inside classes #802

Closed
hollasch opened this issue Nov 13, 2020 · 1 comment
Closed

Move method definitions inside classes #802

hollasch opened this issue Nov 13, 2020 · 1 comment
Assignees
Milestone

Comments

@hollasch
Copy link
Collaborator

We currently define some class methods inside classes, and some outside. Given our code structure (#include all source files from a single main-defining file), this would help keep things clean and consistent.

Some have argued that we should separate method definitions from headers, and I would certainly do that for my own implementation, but that wouldn't buy anything for our expository purposes, and would roughly double the number of source files that people would have to follow.

Currently, book 1 is a little over 1200 lines total, and books 2 & 3 about 2300 lines each. This simplicity serves us and our readers well.

@hollasch hollasch added this to the v4.0.0 milestone Nov 13, 2020
@hollasch hollasch self-assigned this Nov 13, 2020
hollasch added a commit that referenced this issue Dec 7, 2020
@hollasch
Copy link
Collaborator Author

hollasch commented Dec 9, 2020

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant